fix: panic: close of closed channel #5939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for |
|
The usage of |
bombsimon
approved these changes
Jul 15, 2025
Comment on lines
+71
to
+75
| select { | ||
| case <-ctx.Done(): | ||
| return | ||
| default: | ||
| } |
There was a problem hiding this comment.
It should be logically the same but when ctx.Done() is closed ctx.Err() will return a non nil error. Just a personal pref on what's easier to read I guess.
Suggested change
| select { | |
| case <-ctx.Done(): | |
| return | |
| default: | |
| } | |
| if ctx.Err() != nil { | |
| return | |
| } |
There was a problem hiding this comment.
In this situation, for me, checking the error is confusing because we don't expect an error but a stop, and it will act like we are ignoring an error.
It's a personal pref too, but in this context, I prefer using Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used a global cancellable
contextbecausecancelis concurrency safe (and so can be called several times).The background of the problem is the fact of having go routines inside go routines inside go routines.
I think I will rewrite this section at some point.
To reproduce, I replaced
Nextwith a non-existent methodFoo.git clone https://github.com/NVIDIA/aistore.git cd aistore git checkout 7730e4290Fixes #5938
Related to #5929, #5923